Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/paratime): Print ROFL app id in rofl1 format #332

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

amela
Copy link
Member

@amela amela commented Dec 9, 2024

Fixes oasisprotocol/oasis-sdk#2088. It looks like there is no need to add Pretty Print to oasis-sdk. The decoder only needs to be included.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit fe7b432
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/6756bb2807039900089175d2

@amela amela force-pushed the amela/feat/print-rofl-app-id-in-rofl1-format branch from b418a72 to 9528fb2 Compare December 9, 2024 09:39
@amela amela force-pushed the amela/feat/print-rofl-app-id-in-rofl1-format branch from 9528fb2 to fe7b432 Compare December 9, 2024 09:40
@amela amela requested review from matevz and kostko December 9, 2024 09:45
@amela amela marked this pull request as ready for review December 9, 2024 09:52
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good job!

@amela amela merged commit e2942ed into master Dec 9, 2024
4 checks passed
@amela amela deleted the amela/feat/print-rofl-app-id-in-rofl1-format branch December 9, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client-sdk/go: Add pretty printing for rofl.Create event
2 participants